Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CB-13055 Fold all fetch options to `true` #624

Merged
merged 4 commits into from Jul 11, 2018

Conversation

Projects
None yet
3 participants
@raphinesse
Copy link
Contributor

commented Jul 4, 2018

Manual constant folding assuming any fetch options to be true.

Extends #617

@dpogue

dpogue approved these changes Jul 4, 2018

Copy link
Member

left a comment

👍

@raphinesse

This comment has been minimized.

Copy link
Contributor Author

commented Jul 4, 2018

Will check out the failures on Travis 😒

@raphinesse raphinesse force-pushed the raphinesse:fetch-nomore branch from 66d62cb to 7f975c8 Jul 5, 2018

@raphinesse

This comment has been minimized.

Copy link
Contributor Author

commented Jul 5, 2018

Fixed integration-tests/plugman_uninstall.spec.js. Should be good now.

@raphinesse

This comment has been minimized.

Copy link
Contributor Author

commented Jul 5, 2018

The test file that causes the errors on Windows is nasty. I'll DRY it first.

@raphinesse raphinesse closed this Jul 6, 2018

@raphinesse raphinesse reopened this Jul 6, 2018

@raphinesse raphinesse force-pushed the raphinesse:fetch-nomore branch from c344f43 to 7b0086e Jul 6, 2018

@raphinesse

This comment has been minimized.

Copy link
Contributor Author

commented Jul 6, 2018

Never mind the check.js refactor commits they will go in a separate PR. I just wanted to have them here for testing.

@raphinesse raphinesse force-pushed the raphinesse:fetch-nomore branch from eb435d2 to 15b0757 Jul 10, 2018

@raphinesse raphinesse closed this Jul 10, 2018

@raphinesse raphinesse reopened this Jul 10, 2018

@raphinesse raphinesse closed this Jul 10, 2018

@raphinesse raphinesse reopened this Jul 10, 2018

@raphinesse

This comment has been minimized.

Copy link
Contributor Author

commented Jul 11, 2018

OK, I fixed up a few test corner cases in the first commit and added a commit that removes all usage of fetch options in the tests. Could you please take another look @dpogue?

@dpogue

dpogue approved these changes Jul 11, 2018

Copy link
Member

left a comment

👍 Looks good to me!

@raphinesse raphinesse force-pushed the raphinesse:fetch-nomore branch from 15b0757 to e9271dc Jul 11, 2018

@raphinesse raphinesse force-pushed the raphinesse:fetch-nomore branch from e9271dc to c8a1aa9 Jul 11, 2018

@raphinesse raphinesse closed this Jul 11, 2018

@raphinesse raphinesse reopened this Jul 11, 2018

@raphinesse

This comment has been minimized.

Copy link
Contributor Author

commented Jul 11, 2018

OK, I'm done waiting for those awfully slow AppVeyor Tests just to see that one of them timed out again. :rage4:

@raphinesse raphinesse merged commit b8e2c4d into apache:master Jul 11, 2018

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@raphinesse raphinesse deleted the raphinesse:fetch-nomore branch Jul 11, 2018

@raphinesse raphinesse referenced this pull request Sep 11, 2018

Closed

Purge remnants of `fetch` option support #9

4 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.