Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CB-13055 Fold all fetch options to true #624

Merged
merged 4 commits into from Jul 11, 2018
Merged

Conversation

@raphinesse
Copy link
Contributor

@raphinesse raphinesse commented Jul 4, 2018

Manual constant folding assuming any fetch options to be true.

Extends #617

dpogue
dpogue approved these changes Jul 4, 2018
Copy link
Member

@dpogue dpogue left a comment

👍

Loading

@raphinesse
Copy link
Contributor Author

@raphinesse raphinesse commented Jul 4, 2018

Will check out the failures on Travis 😒

Loading

@raphinesse
Copy link
Contributor Author

@raphinesse raphinesse commented Jul 5, 2018

Fixed integration-tests/plugman_uninstall.spec.js. Should be good now.

Loading

@raphinesse
Copy link
Contributor Author

@raphinesse raphinesse commented Jul 5, 2018

The test file that causes the errors on Windows is nasty. I'll DRY it first.

Loading

@raphinesse
Copy link
Contributor Author

@raphinesse raphinesse commented Jul 6, 2018

Never mind the check.js refactor commits they will go in a separate PR. I just wanted to have them here for testing.

Loading

@raphinesse
Copy link
Contributor Author

@raphinesse raphinesse commented Jul 11, 2018

OK, I fixed up a few test corner cases in the first commit and added a commit that removes all usage of fetch options in the tests. Could you please take another look @dpogue?

Loading

dpogue
dpogue approved these changes Jul 11, 2018
Copy link
Member

@dpogue dpogue left a comment

👍 Looks good to me!

Loading

@raphinesse
Copy link
Contributor Author

@raphinesse raphinesse commented Jul 11, 2018

OK, I'm done waiting for those awfully slow AppVeyor Tests just to see that one of them timed out again. :rage4:

Loading

@raphinesse raphinesse merged commit b8e2c4d into apache:master Jul 11, 2018
1 of 2 checks passed
Loading
@raphinesse raphinesse deleted the fetch-nomore branch Jul 11, 2018
src/plugman/fetch.js Show resolved Hide resolved
Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants