CB-13055 Fold all fetch options to true#624
Merged
raphinesse merged 4 commits intoapache:masterfrom Jul 11, 2018
Merged
Conversation
Contributor
Author
|
Will check out the failures on Travis 😒 |
Contributor
Author
|
Fixed |
Contributor
Author
|
The test file that causes the errors on Windows is nasty. I'll DRY it first. |
Contributor
Author
|
Never mind the check.js refactor commits they will go in a separate PR. I just wanted to have them here for testing. |
Contributor
Author
|
OK, I fixed up a few test corner cases in the first commit and added a commit that removes all usage of fetch options in the tests. Could you please take another look @dpogue? |
Contributor
Author
|
OK, I'm done waiting for those awfully slow AppVeyor Tests just to see that one of them timed out again. |
4 tasks
janpio
reviewed
Nov 24, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual constant folding assuming any
fetchoptions to betrue.Extends #617