-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CB-13055 Fold all fetch options to true
#624
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Will check out the failures on Travis 😒 |
Fixed |
The test file that causes the errors on Windows is nasty. I'll DRY it first. |
Never mind the check.js refactor commits they will go in a separate PR. I just wanted to have them here for testing. |
OK, I fixed up a few test corner cases in the first commit and added a commit that removes all usage of fetch options in the tests. Could you please take another look @dpogue? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me!
OK, I'm done waiting for those awfully slow AppVeyor Tests just to see that one of them timed out again. |
Manual constant folding assuming any
fetch
options to betrue
.Extends #617