Set the fetch option to true in plugman

[dpogue]

This should resolve the issues brought up in these comments

Should go in to the next patch release

[brody2consult]

I will take a look. I am wondering if this should target a minor release?

[dpogue]

It sounds like plugman is currently broken unless you run it with --fetch because all of the non-fetch code branches have already been removed from cordova-lib, so I think this is okay for a patch

[brody2consult]

Makes sense to me, given the little knowledge I have of this area. I wonder if we should mark the --fetch option as deprecated for future removal in the CLI?

[raphinesse]

Retriggering AppVeyor tests

[raphinesse]

LGTM. Should we merge it?

FYI: I'm currently preparing a PR that completely removes all fetch options and conditions really

[dpogue]

This was ideally intended for a patch release to fix plugman. I agree that we should go ahead and remove all the fetch-related options on master as part of the next major.

[raphinesse]

@dpogue I agree that it's good to have a minimal impact change for a potential patch release. So is there any reason not to merge this?

[dpogue]

I think it's good to go. Not sure if it makes sense to cherry-pick it into a patch version branch or just merge to master and then remove all the fetch options after.

[raphinesse]

IDK 🤷‍♂️ I'd go with the latter, since it allows us to take immediate action

[dpogue]

👍 We can always cherry pick it from master to wherever it's needed