-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set the fetch option to true in plugman #617
Conversation
I will take a look. I am wondering if this should target a minor release? |
It sounds like plugman is currently broken unless you run it with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me, given the little knowledge I have of this area. I wonder if we should mark the --fetch
option as deprecated for future removal in the CLI?
Retriggering AppVeyor tests |
LGTM. Should we merge it? FYI: I'm currently preparing a PR that completely removes all |
This was ideally intended for a patch release to fix plugman. I agree that we should go ahead and remove all the |
@dpogue I agree that it's good to have a minimal impact change for a potential patch release. So is there any reason not to merge this? |
I think it's good to go. Not sure if it makes sense to cherry-pick it into a patch version branch or just merge to master and then remove all the |
IDK 🤷♂️ I'd go with the latter, since it allows us to take immediate action |
👍 We can always cherry pick it from master to wherever it's needed |
This should resolve the issues brought up in these comments
Should go in to the next patch release