Fix setDefaultTimeout for beforeAll and afterAll #648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the timeout defined by setDefaultTimeout did not apply for beforeAll and afterAll blocks. This change fixes that. The new implementation makes use of the fact that Jasmine processes beforeAll in FIFO order and afterAll in LIFO order.
dpogue
approved these changes
Aug 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the timeout defined by
setDefaultTimeoutdid not apply forbeforeAllandafterAllblocks. This change fixes that.The new implementation makes use of the fact that Jasmine processes
beforeAllin FIFO order andafterAllin LIFO order.This should fix the failing tests for #640.