Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused test fixtures #762

Merged
merged 1 commit into from
Apr 12, 2019

Conversation

raphinesse
Copy link
Contributor

@raphinesse raphinesse commented Apr 12, 2019

Related to #757

These are only test fixtures, so this is a patch-level change.

@raphinesse raphinesse requested review from dpogue and erisu April 12, 2019 12:59
@project-bot project-bot bot added this to 🐣 New PR / Untriaged in Apache Cordova: Tooling Pull Requests Apr 12, 2019
Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

Apache Cordova: Tooling Pull Requests automation moved this from 🐣 New PR / Untriaged to ✅ Approved, waiting for Merge Apr 12, 2019
@codecov-io
Copy link

Codecov Report

Merging #762 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #762   +/-   ##
=======================================
  Coverage   85.71%   85.71%           
=======================================
  Files          50       50           
  Lines        2598     2598           
=======================================
  Hits         2227     2227           
  Misses        371      371

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c017729...392ea04. Read the comment docs.

@raphinesse raphinesse merged commit 07a0dd8 into apache:master Apr 12, 2019
Apache Cordova: Tooling Pull Requests automation moved this from ✅ Approved, waiting for Merge to 🏆 Merged, waiting for Release Apr 12, 2019
@raphinesse raphinesse deleted the delete-unused-fixtures branch April 12, 2019 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Apache Cordova: Tooling Pull Requests
🏆 Merged, waiting for Release
Development

Successfully merging this pull request may close these issues.

None yet

3 participants