Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use up-to-date fixtures in tests #757

Closed
raphinesse opened this issue Mar 27, 2019 · 0 comments · Fixed by #770
Closed

Use up-to-date fixtures in tests #757

raphinesse opened this issue Mar 27, 2019 · 0 comments · Fixed by #770
Assignees
@raphinesse

Comments

@raphinesse
Copy link
Contributor

raphinesse commented Mar 27, 2019 •
edited
Loading

Some of our automated tests use project fixtures. A lot of those are outdated. For example, some of those tests use project fixtures that have outdated cordova-android versions with bundled dependencies installed. Running our tests against these outdated fixtures does not reflect real-world usage.

Instead, a project as created by the currently running version of Cordova should be used.

CC @erisu
@raphinesse raphinesse self-assigned this Mar 27, 2019
@raphinesse raphinesse changed the title Tests use outdated fixtures Use up-to-date fixtures in tests Apr 12, 2019
@raphinesse raphinesse mentioned this issue Apr 12, 2019
Merged
raphinesse added a commit that referenced this issue Apr 12, 2019
@raphinesse
Remove unused fixtures (#762)
07a0dd8 
These are only test fixtures, so this is a patch-level change.

Related to #757
This was referenced Apr 13, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@raphinesse raphinesse

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use up-to-date fixtures in tests raphinesse/cordova-lib
1 participant
@raphinesse