Simpler and better cordova/util.getPlatformApiFunction

[raphinesse]

Motivation and Context

The logic in cordova/util.getPlatformApiFunction was a tad to complex and had a few problems because of that.

During testing I frequently had the situation that an error occurred during loading of a platform API module, mostly because of a missing dependency. This function caught these errors and insted threw an error claiming 'Your ' + platform + ' platform does not have Api.js' which was plainly wrong and confusing.

On top of that came a dead code branch and IMHO unnecessary checks. Enough reason for a rewrite

AFAICT this method is not publicly exposed, so this should be a minor change at most.

Description

• The happy path is unchanged as are the situations in which errors are thrown
• The second argument is now unused and could be removed at the call sites in a following or this PR
• The other notable changes all pertain to logged messages:
  • No more warning that file should be called Api.js
  • No more special error message if platform is a custom one (!platforms[platform])
  • Improved error message if module doesn't implement the expected interface

Testing

The existing tests pass.

[codecov-io]

Codecov Report

Merging #767 into master will increase coverage by 0.14%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master     #767      +/-   ##
==========================================
+ Coverage   85.71%   85.86%   +0.14%     
==========================================
  Files          50       50              
  Lines        2598     2589       -9     
==========================================
- Hits         2227     2223       -4     
+ Misses        371      366       -5

Impacted Files	Coverage Δ
src/cordova/util.js	93.02% <50%> (+2.41%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07a0dd8...66c41f1. Read the comment docs.

[dpogue]

👍

[erisu]

LGTM, only made small changes in my opinion but not actually required.