Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nyc@14 update in devDependencies #783

Merged
merged 1 commit into from
Jun 12, 2019
Merged

Conversation

brodycj
Copy link
Contributor

@brodycj brodycj commented Jun 11, 2019

Platforms affected

All

Motivation and Context

This update resolves the npm audit warning at this time.

Description

see title: nyc@14 update in devDependencies

Testing

  • npm run cover succeeds locally on Node.js versions 6, 8, and 10
  • verified that Travis CI succeeds
  • verified that AppVeyor CI succeeds - on Node.js versions 6 & 8, TBD still queued on Node.js 10

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

Copy link
Contributor

@raphinesse raphinesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me if the failing AppVeyor CI run was just a hiccup.

@brodycj brodycj merged commit 268688a into apache:master Jun 12, 2019
@brodycj brodycj deleted the nyc-14-update branch June 12, 2019 21:43
@raphinesse
Copy link
Contributor

I approved if the failing AppVeyor CI run was just a hiccup. I restarted the failing test on Node 10. But you did not wait for it to finish. Conditional approval seems to be a bad idea 😒

@brodycj brodycj restored the nyc-14-update branch June 12, 2019 21:57
@brodycj
Copy link
Contributor Author

brodycj commented Jun 12, 2019

Oh, I didn't realize you restarted it on Node.js 10. I should have asked for clarification, then.

I will watch the builds on the master branch, just in case.

@raphinesse
Copy link
Contributor

I should have been clearer. I would not expect the update to break the tests, but it's definitely better to check the results on master. Thanks!

@brodycj
Copy link
Contributor Author

brodycj commented Jun 13, 2019

This update still fails on a single end-to-end test on Node.js 10, on AppVeyor. I think we should revert this update and investigate why this failure persists. My bad.

brodycj pushed a commit that referenced this pull request Jun 13, 2019
@brodycj brodycj deleted the nyc-14-update branch June 13, 2019 03:12
@brodycj
Copy link
Contributor Author

brodycj commented Jun 13, 2019

Reverting this PR, as I had proposed in PR #785, did not seem to resolve the test failure on Node.js 10 on AppVeyor. So I think this change should not be reverted, instead I will propose a quick test workaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants