-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nyc@14 update in devDependencies #783
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine by me if the failing AppVeyor CI run was just a hiccup.
I approved if the failing AppVeyor CI run was just a hiccup. I restarted the failing test on Node 10. But you did not wait for it to finish. Conditional approval seems to be a bad idea 😒 |
Oh, I didn't realize you restarted it on Node.js 10. I should have asked for clarification, then. I will watch the builds on the master branch, just in case. |
I should have been clearer. I would not expect the update to break the tests, but it's definitely better to check the results on master. Thanks! |
This update still fails on a single end-to-end test on Node.js 10, on AppVeyor. I think we should revert this update and investigate why this failure persists. My bad. |
Reverting this PR, as I had proposed in PR #785, did not seem to resolve the test failure on Node.js 10 on AppVeyor. So I think this change should not be reverted, instead I will propose a quick test workaround. |
Platforms affected
All
Motivation and Context
This update resolves the
npm audit
warning at this time.Description
see title: nyc@14 update in
devDependencies
Testing
npm run cover
succeeds locally on Node.js versions 6, 8, and 10Checklist
I added automated test coverage as appropriate for this changeCommit is prefixed with(platform)
if this change only applies to one platform (e.g.(android)
)If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)I've updated the documentation if necessary