Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: android 10 configs #202

Merged
merged 1 commit into from
Aug 26, 2020
Merged

feat: android 10 configs #202

merged 1 commit into from
Aug 26, 2020

Conversation

breautek
Copy link
Contributor

@breautek breautek commented Aug 5, 2020

Platforms affected

Android

Motivation and Context

Adds android 10 device as a potential config option.

Description

Testing

Ran npm test, however failing locally, claiming that my android emulator is out of date, when I have the latest available android emulator installed. Want to see if test runs successfully on travis.

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@timbru31
Copy link
Member

Friendly ping @breautek - https://travis-ci.org/github/apache/cordova-paramedic/jobs/715030943 it seems your Android 10 run was successful.

@breautek breautek marked this pull request as ready for review August 26, 2020 17:11
@breautek breautek closed this Aug 26, 2020
@breautek breautek reopened this Aug 26, 2020
@timbru31
Copy link
Member

The iOS failures can be ignored, they are not related to this PR. 👍

@breautek breautek merged commit 326051a into apache:master Aug 26, 2020
@breautek breautek deleted the android10 branch August 26, 2020 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants