Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: (android) use API 29 #411

Merged
merged 2 commits into from Sep 19, 2020
Merged

test: (android) use API 29 #411

merged 2 commits into from Sep 19, 2020

Conversation

breautek
Copy link
Contributor

@breautek breautek commented Aug 5, 2020

Platforms affected

Android

Motivation and Context

Make test use API / Build Tools 29.

Fixes some build errors in travis.

Description

Updates Travis

Testing

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@breautek
Copy link
Contributor Author

breautek commented Aug 5, 2020

@breautek breautek mentioned this pull request Aug 5, 2020
5 tasks
@felipecaparelli
Copy link

Blocked by apache/cordova-paramedic#200 and apache/cordova-paramedic#202

Is there any other blocker?

@breautek
Copy link
Contributor Author

breautek commented Sep 5, 2020

Blocked by apache/cordova-paramedic#200 and apache/cordova-paramedic#202

Is there any other blocker?

We'll see if the tests pass.

@breautek
Copy link
Contributor Author

breautek commented Sep 5, 2020

The failed tests are iOS/browser environments which is unrelated to this PR, so I think it's still okay to merge.

@breautek breautek changed the title WIP: test: (android) use API 29 test: (android) use API 29 Sep 12, 2020
@timbru31 timbru31 merged commit 2bbbb84 into apache:master Sep 19, 2020
pmcquay pushed a commit to BetterImpact/cordova-plugin-file that referenced this pull request Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants