Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add gh-actions workflow #215

Merged
merged 15 commits into from
Aug 28, 2021
Merged

ci: add gh-actions workflow #215

merged 15 commits into from
Aug 28, 2021

Conversation

erisu
Copy link
Member

@erisu erisu commented Aug 27, 2021

Motivation and Context

Migrate paramedic to GH Actions

  • Appium tests are not passing but everything else is running OK. No core plugins uses Appium test for android.

Testing

Checklist

  • I've run the tests to see all new and existing tests pass

timbru31 and others added 4 commits August 28, 2021 03:06
This adds a working example for iOS
The Chrome tests could work in theory.
The Android testsuite currently times out for unknown reasons.
* add caching step
* hoist configurations
* update the step names
@erisu erisu changed the base branch from feat/gh-actions to master August 27, 2021 18:10
@zachawilson
Copy link
Contributor

This is looking good to me.

As additional testing, I have forked and run a GitHub Action workflows for cordova-plugin-statusbar using this cordova-paramedic at the latest commit 2dbc650

Copy link
Member

@dpogue dpogue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see some Q usage here that I'm always in favour of removing, but I suspect that's a much larger task involving the entire paramedic codebase?

lib/appium/AppiumRunner.js Outdated Show resolved Hide resolved
.github/workflows/android.yml Show resolved Hide resolved
@erisu
Copy link
Member Author

erisu commented Aug 28, 2021

As for the Q usage, I think we should remove it but on a separate PR. The rest of the code base is using Q.

@erisu erisu changed the title ci: migrate to gh-actions ci: add gh-actions workflow Aug 28, 2021
@erisu erisu merged commit 95bb3b3 into apache:master Aug 28, 2021
@erisu erisu deleted the feat/gh-actions branch August 28, 2021 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants