(android) allow insecure requests for test results communication #56
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
Motivation and Context
Allowing insecure (HTTP) is necessary for
cordova-paramedic
to work, because thecordova-plugin-test-framework
scripts running in the cordova environment, need to post (HTTP PUT) test results to the local server ofcordova-paramedic
, awaiting the results.To address the need for insecure (HTTP) is why
plugin.xml
is updated to enable bothAndroidInsecureFileModeEnabled=true
andandroid:usesCleartextTraffic=true
.Description
Updated configuration in
plugin.xml
of this project to allow android to make insecure (HTTP) requests.Testing
This is a little bit roundabout because of having
cordova-paramedic
in the loop. Let me know if there is a better test.cordova-paramedic
to reference this patched version ofcordova-plugin-test-framework
this commit 973f131cordova-paramedic --platform android@10.1.0 --plugin cordova-plugin-statusbar
would hang, on the step: "cordova-paramedic: waiting for test results"cordova-plugin-statusbar
against this patched version of cordova paramedicnpm install -g SwitchCaseGroup/cordova-paramedic#ec0a7e0
where the patchedcordova-paramedic
is referencing thisChecklist
(platform)
if this change only applies to one platform (e.g.(android)
)