CB-8929 Use PowerManager to get battery state on Win 10 #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daserge
reviewed
Nov 8, 2016
| }, { keepCallback: true }); | ||
| } | ||
|
|
||
| PowerManager.onremainingchargepercentchanged = reportStatus; |
There was a problem hiding this comment.
Would not it be better to use add/remove event listener here instead to avoid overriding a listener which might be set in an app code?
|
Tested and it works good on all targets (Win 10 desktop, Win 10 Mobile, Windows Phone 8.1). |
|
@daserge, addressed your notes |
|
@vladimir-kotikov LGTM, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
Windows (specifically Windows 10)
What does this PR do?
Adds support for Windows 10
What testing has been done on this change?
Manual testing
Checklist