Fix for CB-10050 : Plugin Camera : Inconsistent saveToPhotoAlbum beha… #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vior on PHOTOLIBRARY images
|
@omefire can you take a look at this? |
|
I think this change is not necessary because the user could have edited the picture they picked from the PHOTOLIBRARY and want it saved (even though it ends up being saved twice). This verification, in my opinion, is better left to the user of the plugin. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…vior on PHOTOLIBRARY images
If sourceType == UIImagePickerControllerSourceTypePhotoLibrary
Then saveToPhotoAlbum is set False Always.