Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added github action workflow to run tests #745

Merged
merged 2 commits into from
Aug 11, 2021

Conversation

purplecabbage
Copy link
Contributor

Platforms affected

Motivation and Context

Description

Testing

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@erisu
Copy link
Member

erisu commented Aug 11, 2021

I rebased the PR and also removed the codecov step.

For codecov to work, we should have a testing framework that runs and generates code coverage reports. All of our plugins do not run any unit tests to create these reports. There is nothing to upload, so the best solution at this time is to remove the codecov step.

@erisu erisu merged commit c56a255 into apache:master Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants