-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CB-12667 android: Added logic for searching sensors from Samsung vendor #34
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Anything else needed to merge this in?
@matrosov-nikita Which Samsung devices are affected? All of them? Only the Samsung Galaxy S3/4/5? If we could get more info on that, we can test for this and try and make there there's no regressions. |
@infil00p, sorry for late reply, I've tested a plugin with two Samsung devices:
For Samsung Galaxy S5 plugin works perfect. So, not all devices are affected. It depends on what orientation sensors the device has. |
A quick Google search reveals that the Note 2 and Note 4 also have this sensor type: http://www.mattcurry.com/projects-2/the-n-a-o-m-i-project/note4-sensor-output/ Interestingly, the only device I was able to dig up that has the Samsung-specific orientation sensor but not the "normal" orientation sensor is the SM-G361H model @matrosov-nikita points out. @matrosov-nikita are you able to confirm that this device's Samsung Orientation Sensor works and provides the same kind of data as the regular android Orientation sensor? |
@filmaj, I can confirm that auto and manual tests work w/ my fix. |
This commit will fix the compass problem on samsung devices? e.g. Samsung Galaxy J5 (2016) |
@petrot, what do you mean 'compass problem'. Do you have any particular cases which don't work for you? I could test them with this fix. |
One of my user has a Galaxy J5, but as I recognized yesterday, this phone does not have a sensor. So my problem has been solved.. :) |
@matrosov-nikita as long as you tested this on one of the real devices affected by the issue, and confirmed the fix, I am good to have this merged. |
Just realized you don't have committer rights - I will merge this in. |
@matrosov-nikita can you rebase with latest master first, please? |
f055c16
to
a77b4fa
Compare
@filmaj, done |
Platforms affected
Android
What does this PR do?
This PR adds opportunity for searching orientation sensors which have specific orientation type (it's relevant for Samsung devices).
Checklist