Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(electron): add support #135

Merged
merged 5 commits into from
Mar 31, 2022
Merged

feat(electron): add support #135

merged 5 commits into from
Mar 31, 2022

Conversation

erisu
Copy link
Member

@erisu erisu commented Nov 17, 2020 •
edited
Loading

Platforms affected

electron

Motivation and Context

Add Electron Support

closes: #102
closes: #99

Description

Added sub-npm-package for Cordova-Electron

Testing

  • Build Test

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@timbru31
Copy link
Member

Does this supersede #102 and close #99?

@erisu
Copy link
Member Author

erisu commented Nov 17, 2020 •
edited
Loading

#102 is only based off the user agent string which can change at anytime and also users can change it on their own. Also this uses browser platform code. Browser platform code lacks ability to grab UUID and other things so its not really a good solution for electron support

In short it will close both.

@erisu erisu marked this pull request as draft November 17, 2020 09:58
@erisu erisu marked this pull request as ready for review September 6, 2021 05:02
breautek
breautek approved these changes Sep 6, 2021
View reviewed changes
Copy link
Contributor

@breautek breautek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm -- but travis tests are reporting eslint errors that should be resolved.

NiklasMerz
NiklasMerz approved these changes Sep 6, 2021
View reviewed changes
Copy link
Member

@NiklasMerz NiklasMerz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erisu erisu force-pushed the feat/electron-support branch 2 times, most recently from 3f06fbe to 71dd844 Compare September 7, 2021 04:58
@erisu erisu merged commit f6cf8a6 into apache:master Mar 31, 2022
@erisu erisu deleted the feat/electron-support branch March 31, 2022 03:32
@erisu erisu mentioned this pull request Apr 3, 2022
Open
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NiklasMerz NiklasMerz NiklasMerz approved these changes

@breautek breautek breautek approved these changes

@purplecabbage purplecabbage Awaiting requested review from purplecabbage

@raphinesse raphinesse Awaiting requested review from raphinesse

@timbru31 timbru31 Awaiting requested review from timbru31

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for electron platform
4 participants
@erisu @timbru31 @NiklasMerz @breautek