Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: eslint upgrade #325

Merged
merged 1 commit into from
Jun 14, 2022
Merged

chore: eslint upgrade #325

merged 1 commit into from
Jun 14, 2022

Conversation

breautek
Copy link
Contributor

@breautek breautek commented Jan 6, 2022

Platforms affected

All

Motivation and Context

Depends on #324

Upgrades and fixes ESlint errors

Description

Upgrades Eslint to the latest cordova eslint config & applied the eslint fixes

Testing

Ran npm test successfully.

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@erisu erisu changed the title Eslint upgrade chore: eslint upgrade Jan 6, 2022
Copy link
Member

@NiklasMerz NiklasMerz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once CI and tests are good. Or is paramedic broken for this plugin?

@breautek
Copy link
Contributor Author

breautek commented Jan 7, 2022

LGTM once CI and tests are good. Or is paramedic broken for this plugin?

Not sure -- because the CI was green with the exception of Chrome Test suite but turned red even on non-code changes (like the npmrc config pr). So with that being said, it seems like paramedic is still unstable.

@breautek breautek merged commit 6153f6d into apache:master Jun 14, 2022
@breautek breautek deleted the eslint-upgrade branch June 14, 2022 16:41
dpalou pushed a commit to moodlemobile/cordova-plugin-file-transfer that referenced this pull request Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants