Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support android 10 (API 29) #410

Closed
wants to merge 4 commits into from
Closed

Conversation

eliadAfeka
Copy link

@eliadAfeka eliadAfeka commented Aug 4, 2020

Platforms affected

Motivation and Context

Description

added as a fix for #408

Testing

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@breautek
Copy link
Contributor

breautek commented Aug 5, 2020

Blocked by #411

plugin.xml Outdated Show resolved Hide resolved
eliadAfeka and others added 3 commits August 8, 2020 07:50
Co-authored-by: Norman Breau <norman@normanbreau.com>
@breautek
Copy link
Contributor

@eliadAfeka Looks like you just reverted this PR via 28aa712, so that this no has no changes

@jitendracodehacker
Copy link

jitendracodehacker commented Aug 14, 2020

@breautek Hi , When will you have support to API29. this has stopped our release as file-plugin fails.

@felipecaparelli
Copy link

I'm just wondering, it this plugin.xml change the only thing needed to be compliant with Android 10?

@breautek
Copy link
Contributor

I'm just wondering, it this plugin.xml change the only thing needed to be compliant with Android 10?

From what I've seen, yes.

@breautek breautek mentioned this pull request Sep 12, 2020
5 tasks
@eliadAfeka
Copy link
Author

hi,

sorry for the rush, but is everything ok with this PR? if yes, when you are going to upload it?
this plugin is critical in my projects.

thanks.

@smartyw
Copy link

smartyw commented Oct 2, 2020

I believe this PR, which was supposed to fix this issue was merged so I built against head just now but still get the same error INVALID_MODIFICATION_ERR when running on Android 10. Is this expected? Do I need to wait for an official release of the plugin? There's some urgency to get applications using target SDK 29 by November. Thanks.

@EinfachHans
Copy link

@breautek Any chance we can get a new released Version here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants