Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android): create toURL override to preserve other platforms #516

Merged
merged 1 commit into from
Mar 29, 2022
Merged

fix(android): create toURL override to preserve other platforms #516

merged 1 commit into from
Mar 29, 2022

Conversation

erisu
Copy link
Member

@erisu erisu commented Mar 28, 2022

Platforms affected

all

Motivation and Context

Recent changes to toURL should only be applied to Android

Description

Created an Android only override and reverted original code.

Testing

  • cordova build
  • run tests

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@erisu erisu requested a review from breautek March 28, 2022 23:06
breautek
breautek approved these changes Mar 28, 2022
View reviewed changes
Copy link
Contributor

@breautek breautek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@erisu erisu merged commit 2ecccbf into apache:master Mar 29, 2022
@erisu erisu deleted the fix/add-android-toURL-override branch March 29, 2022 00:04
pmcquay pushed a commit to BetterImpact/cordova-plugin-file that referenced this pull request Sep 2, 2022
@erisu @pmcquay
fix(android): create toURL override to preserve other platforms (apac…
0fe72d5 
…he#516)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breautek breautek breautek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@erisu @breautek