CB-14085: Fix iOS usage description #106
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR, but we removed this on purpose because plugin variables cause conflicts with other plugins setting the same fields. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
iOS
What does this PR do?
This PR makes the plugin works properly on iOS without extra changes in the config.xml and without conflicts with other plugins. The README.md is updated accordingly.
What testing has been done on this change?
This PR replaces the tag edit-config by the tag config-file in the test context plugin.xml.
The cordova documentation imply config-file is designed and tested for iOS plist.info when edit-config is designed for more complex xml syntax, like an android manifest.xml file. The merge mode available for edit-config is designed for merging up two tags with attributes (xml tags in a plist have no attributes).
According the documentation, using edit-config on a plist.info file is not a secure practice. Adding the mode attribute to "merge" makes it worst.
If a third plugin make wrong things in its plugin.xml, it may create issues and conflicts, but it won't be coming from this PR.
This PR is tested and reliable.