Skip to content

Commit

Permalink
(iOS) Fix iframes in iOS/WKWebView which were broken by #418. Fixes #424
Browse files Browse the repository at this point in the history
. (#425)
  • Loading branch information
dpa99c authored and janpio committed Feb 11, 2019
1 parent ae329bc commit 388e3f6
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions src/ios/CDVWKInAppBrowser.m
Original file line number Diff line number Diff line change
Expand Up @@ -573,9 +573,9 @@ - (void)webView:(WKWebView *)theWebView decidePolicyForNavigationAction:(WKNavig
}

if(shouldStart){
// Fix GH-417: Handle non-default target attribute
// Based on https://stackoverflow.com/a/25853806/777265
if (!navigationAction.targetFrame.isMainFrame){
// Fix GH-417 & GH-424: Handle non-default target attribute
// Based on https://stackoverflow.com/a/25713070/777265
if (!navigationAction.targetFrame){
[theWebView loadRequest:navigationAction.request];
decisionHandler(WKNavigationActionPolicyCancel);
}else{
Expand Down

0 comments on commit 388e3f6

Please sign in to comment.