Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove window.open overwrite #599

Closed
NiklasMerz opened this issue Dec 30, 2019 · 0 comments · Fixed by #600
Closed

Remove window.open overwrite #599

NiklasMerz opened this issue Dec 30, 2019 · 0 comments · Fixed by #600
Milestone

Comments

@NiklasMerz
Copy link
Member

NiklasMerz commented Dec 30, 2019

Feature Request

Motivation Behind Feature

Like described in the README file a long time ago there was a plan to remove the backwards compatibility of overwriting window.open in a future release. [See](WKWebViewOnly https://github.com/apache/cordova-plugin-inappbrowser#windowopen)

For backwards compatibility, this plugin also hooks window.open. However, the plugin-installed hook of window.open can have unintended side effects (especially if this plugin is included only as a dependency of another plugin). The hook of window.open will be removed in a future major release. Until the hook is removed from the plugin, apps can manually restore the default behaviour:

Feature Description

We should remove this overwrite of the native browser window function to avoid errors like this:

#315
#403

Alternatives or Workarounds

A proposal to change the docs exists #528

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant