-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CB-7179 (iOS): Finish off WKWebView implementation #245
Conversation
also added resources and fixed file paths, renamed test dir, added nested plugin.xml github: close 55
- move the resources from /resources to /cdvtests/iab-resources - change the url of the resources from absolute to relative - explicitly set the background color of local.html to be white because it was inheriting black - add the js to display the user-agent on the tests menu - change the www.google.com URL from http to https to avoid an unexpected redirect
- fix the paths to the injected resources - update the urls to Google home page to use https to avoid redirects - get the user agent to display on the inject.html page
…a-plugin-inappbrowser
This change supports Android and Amazon Fire OS
…a-plugin-inappbrowser
…a-plugin-inappbrowser
Added logs and corrected indentation according to 81161eb
…a-plugin-inappbrowser
…ad of an object, aligning it with the other platforms.
This closes apache#228
…rowser and browser implementation
… lists for better developer experience
…UIWebView. Adds dependency on cordova-plugin-wkwebview-engine. Fix content sizing bug caused by 4573c87d0b74c087ef35e40f4311674bc92e7947
This needs to be cleaned up, since there's too many commits from other people in this PR. Can you do this PR again, this time with just the code that you authored in the PR? |
@infil00p The original apache/wkwebview branch that I made as the merge target was last updated by @shazron in 2014, so is majorly out of date with respect to apache/master. So my Would you rather I fork the current |
@infil00p @stevengill @agrieve @shazron @purplecabbage How should I proceed with this? I have a fork of this plugin as cordova-plugin-inappbrowser-wkwebview which implements WKWebview for the InappBrowser for iOS. The implementation is based on @shazron's apache/wkwebview branch from 2014, but I've committed it against a fork of apache/master since this is much more update-to-date with respect to other platforms than apache/wkwebview. The current implementation drops support for the UIWebView implementation in favour of WKWebView, so relies on |
@dpa99c We didn't see this comment on the closed commit until someone pointed this out on the vote thread. If you could modify it to conditionally switch, that would make it easier, but I'm also not the authority on iOS (I've only recently been starting to triage the iOS issues). I would send the PR as is for discussion, or start a discussion on the dev list about this. |
@infil00p UIWebView deprecated on iOS 12 - OK, time to revive this. I'll see if I can put together a dual implementation which enables you to switch between UIWebView and WKWebView in IAB. I should be able to make that PR against master since it will be suitable for mainstream release. |
Platforms affected
iOS
What does this PR do?
This PR builds on the initial work done by Shazron in https://github.com/apache/cordova-plugin-inappbrowser/tree/wkwebview:
What testing has been done on this change?
Run automated tests as outlined here.
All tests pass for iOS platform:
Note: other platforms not tested because they have not been changed.
Checklist