Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes loadAfterBeforeload on iOS. Resolves #349. #350

Merged
merged 1 commit into from
Nov 21, 2018
Merged

Fixes loadAfterBeforeload on iOS. Resolves #349. #350

merged 1 commit into from
Nov 21, 2018

Conversation

dpa99c
Copy link
Contributor

@dpa99c dpa99c commented Nov 20, 2018 •
edited by janpio
Loading

For both UIWebView and WKWebView implementations on iOS.

Platforms affected

iOS

What does this PR do?

Fixes beforeload event (introduced by #276) for iOS

What testing has been done on this change?

Tested both allow & deny loading of URL with both iOS implementations in test container app (ignore its README).

  • To test with UIWebView use options: beforeload=yes,usewkwebview=no
  • To test with WKWebView use options: beforeload=yes,usewkwebview=yes

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

closes #349

@janpio janpio merged commit 0fd43ae into apache:master Nov 21, 2018
@dpa99c dpa99c mentioned this pull request Nov 30, 2018
Closed
@dependabot dependabot bot mentioned this pull request Mar 16, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janpio janpio janpio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@dpa99c @janpio