fix(android): add space between default useragent and custom AppendUserAgent #861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erAgent cordova-android adds a space between the default user agent and the custom one: https://github.com/apache/cordova-android/blob/c144c0811249e22f91253ef919cc767f892a8fdf/framework/src/org/apache/cordova/engine/SystemWebViewEngine.java#L214 With this change cordova-androids and the IAB user agent are exactly the same.
timbru31
approved these changes
Apr 2, 2021
jcesarmobile
approved these changes
May 28, 2021
MaximBelov
pushed a commit
to MaximBelov/cordova-plugin-inappbrowser
that referenced
this pull request
Aug 25, 2022
…erAgent (apache#861) cordova-android adds a space between the default user agent and the custom one: https://github.com/apache/cordova-android/blob/c144c0811249e22f91253ef919cc767f892a8fdf/framework/src/org/apache/cordova/engine/SystemWebViewEngine.java#L214 With this change cordova-androids and the IAB user agent are exactly the same.
pesi-hgc
pushed a commit
to pesi-hgc/cordova-plugin-inappbrowser-transparent
that referenced
this pull request
Nov 3, 2023
…erAgent (apache#861) cordova-android adds a space between the default user agent and the custom one: https://github.com/apache/cordova-android/blob/c144c0811249e22f91253ef919cc767f892a8fdf/framework/src/org/apache/cordova/engine/SystemWebViewEngine.java#L214 With this change cordova-androids and the IAB user agent are exactly the same.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
Android
Motivation and Context
cordova-android adds a space between the default user agent and the custom one
(https://github.com/apache/cordova-android/blob/c144c0811249e22f91253ef919cc767f892a8fdf/framework/src/org/apache/cordova/engine/SystemWebViewEngine.java#L214) and the InAppBrowser does not. If a user/applications expect them to be equal this could cause an error.
Description
With this change cordova-androids and the IAB user agent are exactly the same.
Testing
Manual testing, no tests for useragent found
Checklist
(platform)if this change only applies to one platform (e.g.(android))