Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): set category before creating AVAudioRecorder #269

Merged
merged 1 commit into from Jul 20, 2023

Conversation

knight9999
Copy link
Contributor

@knight9999 knight9999 commented May 16, 2023

Platforms affected

iOS

Motivation and Context

Fixes #267

i.e. Recording audio doesn't work on iOS 6.2 or newer.

Description

I changed setting category AVAudioSessionCategoryPlayAndRecord before creating AVAudioRecorder.
This is according to the comment #267 (comment) .

Testing

In my local environment, I tested by creating cordova sample project and confirm the recording method (navigator.device.capture.captureAudio) works well on following devices.

iPhone SE 2th iOS 16.4.1 (a)
iPhone 12 iOS 15.0
iPad Air 4th iOS 16.3.1

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@knight9999 knight9999 requested a review from erisu May 16, 2023 05:17
@erisu erisu changed the title (iOS) fix issue-267 by setting category before creating AVAudioRecorder fix(ios): set category before creating AVAudioRecorder Jun 7, 2023
Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erisu erisu merged commit 8547af0 into apache:master Jul 20, 2023
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recording interface is broken
2 participants