CB-12849: checking mediaState in destroy method, and moving file by stream when renameTo failing #168
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
android
What does this PR do?
Resolving recording audio issue.
File.renameTo method used in AudioPlayer.java can not move file across partitions.
Then I developed copying the file by using i/o stream when renameTo failing.
media.stopRecord() in JS calls stopRecording in Java,
However media.release() in JS also calls stopRecording in Java via destroy method.
The second call of stopRecording overrides the audio file with empty.
This PR prevents the unnecessary call of stopRecording.
What testing has been done on this change?
sample code is
Checklist