Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Upgrade build tools to use modern tooling & device profiles #79

Closed
wants to merge 1 commit into from

Conversation

breautek
Copy link
Contributor

Platforms affected

CI

Motivation and Context

Progresses apache/cordova#223

Description

Updates CI configs to use modern tooling and device profiles.

Testing

Ran npm test

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@breautek breautek marked this pull request as draft February 28, 2021 15:40
@breautek
Copy link
Contributor Author

Test is failing on desktop browsers for this reason: #35 (comment)

Desktop browsers now implements the APIs, so we use them, but they will reject as you can't lock an orientation on desktop.

On rejection, we will fallback to a cordova bridge, but we don't actually have a browser implementation for the fallback, thus resulting to cordova.js:1001 Error: exec proxy not found for :: CDVOrientation :: screenOrientation message.

It sounds like these tests are going to have to be spied on to simulate, but we also should probably return a meaningful message when running in an environment that doesn't actually support orientation locking.

I haven't tested yet, but I assume this works as intended in the mobile browser.

@breautek
Copy link
Contributor Author

Closing because we have moved away from appveyor/travis making this PR obsolete.

@breautek breautek closed this Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant