Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Added iOS notes to supported platforms. #300

Merged
merged 1 commit into from
Oct 17, 2020

Conversation

breautek
Copy link
Contributor

Platforms affected

Docs

Motivation and Context

Updated iOS supported platform documentation to hopefully clarify some confusion as shown here and here

Description

Add mention that if you're using cordova-ios@5 then you should remain on version 5 of this plugin. If you're using cordova-ios@6 then you should be using version 6 of this plugin, or if you're developing exclusively for iOS, then it's safe to uninstall this plugin altogether.

Please let me know if the wording should be altered.

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

Copy link
Member

@timbru31 timbru31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and is understandable 👍

@breautek breautek merged commit eb0d0e5 into apache:master Oct 17, 2020
@breautek breautek deleted the ios-supported-platforms branch October 17, 2020 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants