Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New feature 'styleAndroidTranslucent' #51

Closed
wants to merge 2 commits into from

Conversation

aegliv
Copy link

@aegliv aegliv commented Mar 10, 2016

Replaces the need for following plugin: ekuwang / cordova-plugin-statusbar

@FdezRomero
Copy link

This is awesome, I hope it gets merged soon 👍

@ojoanalogo
Copy link

I tested this feature on Motorola devices and it looks good, but this isn't the case when testing on Samsung and Sony Xperia devices, the statusbar doesn't look transparent and it's more like a dark gradient on the top.
screenshot_2016-04-19-17-43-15

This isn't the case when using apps like Google Play, they have a correct transparent statusbar whilst this not.

@FdezRomero
Copy link

FdezRomero commented May 11, 2016

Pushing this PR from oblivion: Maybe Google Play uses AppCompat and that's why it has a Material-style translucent status bar? I'm not sure if this is possible, just wondering.

Anyway, the option in @MrArc screenshot seems totally acceptable in Android 4.x devices, as I guess is the default behavior.

P.S. It would be great if this feature could be mapped like this for Android, as it already exists in iOS:

<preference name="StatusBarStyle" value="blacktranslucent" />

@ojoanalogo
Copy link

Sorry, i forgot to say that the device was running Android 5.1, which is weird because Lollipop has support for translucent statusbar.

@FdezRomero
Copy link

@MrArc My bad, I thought it was 4.x because the home button is not a circle. The code in the PR just reverses the two flags set by the plugin. Maybe is related to OEMs changing this when they apply their own personalization to the UI?

@cordova-qa
Copy link

Cordova CI Build has completed successfully.

Commit - Link
Dashboard - Link

Builder Name Console Output Test Report Device Logs
Windows 8.1 Store Link Link Link
Windows 10 Store Link Link Link
Windows 8.1 Phone Link Link Link
iOS Link Link Link
Android Mac Link Link Link
Android Windows Link Link Link

@fentas
Copy link

fentas commented Jun 14, 2016

+1 for blacktranslucent
For me transparent statusbar is only working with this pull. :/
Android 5.0.1.

Please merge.

@Ajaxy
Copy link

Ajaxy commented Jun 22, 2016

Will it be merged?

@gedeagas
Copy link

Great Work, @aegliv

Please merge this.

@anymos
Copy link

anymos commented Jul 24, 2016

Good job and +1, I would love to see this PR merged as well, especially that ekuwang / cordova-plugin-statusbar , is having a few bugs. Any ETA

@anymos
Copy link

anymos commented Jul 25, 2016

Hmm, still having an issue the translucent status bar is visible only when in fullScreen mode :-( which is coming with it s own lot of issue. Anyway to make it transparent with a webOverlay without having to set the mode to immersive ?

@aegliv
Copy link
Author

aegliv commented Jul 30, 2016

@MrArc & @anymos:
It works for us on multiple Nexus, LG and Samsung devices without Immersive.
If it doesn't work for you, it is probably related to other settings made prior or after the flags are set with styleAndroidTransparent().

Please try to debug the flag settings in StatusBar.java

@psirenny
Copy link

This pull isn't going anywhere. Is anyone - who is seeing a gradient instead of a translucent bar - willing to debug this in order to move it forward?

@kosssi
Copy link

kosssi commented Sep 27, 2016

👍

@FdezRomero
Copy link

If nobody is able to replicate the gradient status bar in 5.x+ and debug, let's move on and merge this already. It's ridiculous, it has been 9 months already!

@LufoX11
Copy link

LufoX11 commented Aug 17, 2017

Any reason it hasn't been already merged? I mean, for a Ionic development this is almost REQUIRED. The current bar looks completly bad when a modal or something involving an opaque background layer is displayed:

statusbar_50

What do you need or what are you waiting for to modernize this component?

@janpio
Copy link
Member

janpio commented Aug 17, 2017

The probability of merging pull requests are higher when they follow the Pull Request template of the project: https://github.com/apache/cordova-plugin-statusbar/blob/master/.github/PULL_REQUEST_TEMPLATE.md This one, for example, needs an issue at the official issue tracker.

Also: No conflicts with current master and no uncommented problems in the comments of the PR helps.

@infil00p
Copy link
Member

This looks incredibly similar to #78, if this is the case, I'm definitely going to be closing this one in favour of that PR that merges more cleanly.

@asfgit asfgit closed this in ca3da11 Oct 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet