-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New feature 'styleAndroidTranslucent' #51
Conversation
This is awesome, I hope it gets merged soon 👍 |
Pushing this PR from oblivion: Maybe Google Play uses AppCompat and that's why it has a Material-style translucent status bar? I'm not sure if this is possible, just wondering. Anyway, the option in @MrArc screenshot seems totally acceptable in Android 4.x devices, as I guess is the default behavior. P.S. It would be great if this feature could be mapped like this for Android, as it already exists in iOS:
|
Sorry, i forgot to say that the device was running Android 5.1, which is weird because Lollipop has support for translucent statusbar. |
@MrArc My bad, I thought it was 4.x because the home button is not a circle. The code in the PR just reverses the two flags set by the plugin. Maybe is related to OEMs changing this when they apply their own personalization to the UI? |
Cordova CI Build has completed successfully. Commit - Link
|
+1 for blacktranslucent Please merge. |
Will it be merged? |
Great Work, @aegliv Please merge this. |
Good job and +1, I would love to see this PR merged as well, especially that ekuwang / cordova-plugin-statusbar , is having a few bugs. Any ETA |
Hmm, still having an issue the translucent status bar is visible only when in fullScreen mode :-( which is coming with it s own lot of issue. Anyway to make it transparent with a webOverlay without having to set the mode to immersive ? |
This pull isn't going anywhere. Is anyone - who is seeing a gradient instead of a translucent bar - willing to debug this in order to move it forward? |
👍 |
If nobody is able to replicate the gradient status bar in 5.x+ and debug, let's move on and merge this already. It's ridiculous, it has been 9 months already! |
The probability of merging pull requests are higher when they follow the Pull Request template of the project: https://github.com/apache/cordova-plugin-statusbar/blob/master/.github/PULL_REQUEST_TEMPLATE.md This one, for example, needs an issue at the official issue tracker. Also: No conflicts with current |
This looks incredibly similar to #78, if this is the case, I'm definitely going to be closing this one in favour of that PR that merges more cleanly. |
Replaces the need for following plugin: ekuwang / cordova-plugin-statusbar