-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CB-11858: (android) Add StatusBarStyle feature support for Android M+ #78
Conversation
Just fyi, I also did some things a long time ago in #64. Nothing did happen to it though.... |
Two PRs for the same feature, wow! Thanks you two. Have either of you signed an ICLA? |
@filmaj I did, actually. |
@filmaj Yes, I also did 3 days ago. |
@tobiasviehweger For the blacktranslucent behavior, I used this plugin README:
And I also had a look on Apple Developer about blackTranslucent:
So it's the same as black:
And now both blackTranslucent and blackOpaque seem both deprecated in UIStatusBarStyle (as you mentioned in your PR). However, the devgirl blog you used as a reference state the opposite:
So if she's right, we also have to change this plugin README. And for the default value in Android, I used lightContent (white on black) because it's backward compatible with the current style (white status bar text). |
Excellent, thanks for signing the ICLA! Ping @hollyschinsky - can you check what @urmx and @tobiasviehweger mention here with respect to the blacktranslucent/blackopaque bits mentioned in your blog post? |
@filmaj @urmx @tobiasviehweger It's a bit confusing with iOS because the status bar styling has changed several times and the My blog post was correct at the time but since the deprecation, the code in the StatusBar plugin has been updated. If you look at these methods now, those two deprecated styles are only specifically applied when the version is pre 7. Otherwise that code will set it to the Also, make note that the In summary... when using this plugin for iOS:
|
@filmaj @urmx @tobiasviehweger can we get this PR merged? Thanks |
What happens when we test this on Android versions earlier than Android M? We currently support every Android version higher than API 19, so if we could get some more testing on this, that would be greatly appreciated. |
BTW: I'm going to go with this one since it merges more cleanly. I'm going to close #64 |
Platforms affected
Android 6.0+ (API level 23+)
What does this PR do?
This PR add StatusBarStyle feature support for Android 6.0+ (Marshmallow, API level 23+).
The existing "StatusBarStyle" preference is used, and according to the README.md, the possible case-insensitive values are:
This value can also be changed with the existing javascript functions:
StatusBar.styleDefault()
StatusBar.styleLightContent()
StatusBar.styleBlackTranslucent()
StatusBar.styleBlackOpaque()
The default value is "lightcontent" as specified in the README (thus backward compatible with the previous style).
What testing has been done on this change?
Checklist