This repository has been archived by the owner on Jan 9, 2023. It is now read-only.
CB-11516 windows: Preparing icons w/ target fails #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Putting the following line in the config will will cause an error: "Source directory does not exist: Square44x44Logo_100.scale" <icon src="res/Windows/Square44x44Logo_100.png" target="SmallIcon"/> In prepare.js, `copyImages` calls `mapImageResources` but subdirectory information was lost. `copyMrtImage` in an earlier commit preserved this information (shown in the link below), but it was lost in a refactoring. https://github.com/apache/cordova-windows/blob/c1b80be51cdbd90160b6cb8162350bced8e1c44b/template/cordova/lib/prepare.js#L316 This was missed by a defect in the `copyIcons` test in Prepare.Win10.spec.js: `readdirSync` was spied on to return an array of file paths when it actually only returns an array of the filenames. This caused the `copyIcons` spec to pass but the code failed when used.
Current coverage is 72.17%@@ master #179 diff @@
==========================================
Files 14 14
Lines 1905 1905
Methods 351 351
Messages 0 0
Branches 385 385
==========================================
Hits 1375 1375
Misses 530 530
Partials 0 0
|
|
LGTM |
vladimir-kotikov
pushed a commit
to vladimir-kotikov/cordova-windows
that referenced
this pull request
Jul 8, 2016
asfgit
pushed a commit
that referenced
this pull request
Jul 11, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Putting the following line in the config will will cause an error: "Source
directory does not exist: Square44x44Logo_100.scale"
In prepare.js,
copyImagescallsmapImageResourcesbut subdirectoryinformation was lost.
copyMrtImagein an earlier commit preserved thisinformation (shown in the link below), but it was lost in a refactoring.
cordova-windows/template/cordova/lib/prepare.js
Line 316 in c1b80be
This was missed by a defect in the
copyIconstest inPrepare.Win10.spec.js:
readdirSyncwas spied on to return an array of file paths when itactually only returns an array of the filenames. This caused the
copyIconsspec to pass but the code failed when used.