Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

CB-11516 windows: Preparing icons w/ target fails #179

Closed
wants to merge 1 commit into from
Closed

CB-11516 windows: Preparing icons w/ target fails #179

wants to merge 1 commit into from

Commits on Jun 30, 2016

  1. CB-11516 windows: Preparing icons w/ target fails 

    Putting the following line in the config will will cause an error: "Source
directory does not exist: Square44x44Logo_100.scale"
<icon src="res/Windows/Square44x44Logo_100.png" target="SmallIcon"/>
In prepare.js, `copyImages` calls `mapImageResources` but subdirectory
information was lost. `copyMrtImage` in an earlier commit preserved this
information (shown in the link below), but it was lost in a refactoring.
https://github.com/apache/cordova-windows/blob/c1b80be51cdbd90160b6cb8162350bced8e1c44b/template/cordova/lib/prepare.js#L316
This was missed by a defect in the `copyIcons` test in
Prepare.Win10.spec.js:
`readdirSync` was spied on to return an array of file paths when it
actually only returns an array of the filenames. This caused the
`copyIcons` spec to pass but the code failed when used.
    Cody Hoover committed Jun 30, 2016
    Configuration menu
    Copy the full SHA
    0f1be17 View commit details
    Browse the repository at this point in the history