Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

CB-11993 - windows platform doesn't test all node versions on appveyor and travis #201

Closed
wants to merge 1 commit into from

Conversation

shazron
Copy link
Member

@shazron shazron commented Oct 15, 2016

Platforms affected

Self.

What does this PR do?

Makes appveyor and travis CI test for all node versions.

What testing has been done on this change?

We'll find out if this PR passes on appveyor or travis, since we are modifying the CI config files themselves.

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

@shazron
Copy link
Member Author

shazron commented Oct 15, 2016

Failing on Travis 0.12, 4, and 6 (but works on 0.10).
Env vars expected are null because Travis is on Linux and not on Windows. e.g

var programFilesPath = process.env['ProgramFiles(x86)'] || process.env['ProgramFiles'];

We need to mock the env var in the test, like the deployment tests that follow the failing tests

@codecov-io
Copy link

codecov-io commented Oct 15, 2016

Current coverage is 74.34% (diff: 100%)

Merging #201 into master will not change coverage

@@             master       #201   diff @@
==========================================
  Files            14         14          
  Lines          1949       1949          
  Methods         366        366          
  Messages          0          0          
  Branches        392        392          
==========================================
  Hits           1449       1449          
  Misses          500        500          
  Partials          0          0          

Powered by Codecov. Last update 1417b93...ea82902

@asfgit asfgit closed this in 57de5e0 Oct 15, 2016
@shazron shazron deleted the CB-11993 branch October 15, 2016 08:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants