This repository has been archived by the owner on May 25, 2021. It is now read-only.
Let "error" replication document updates bypass the VDU function. #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary in the case where an software upgrade happens with a more restrictive VDU function. Replicator db might end up having documents which would not pass validation anymore, leading to a replicator manager crash when it updates the document with an "error" state. So in case of an "error" state allow malformed document so the user can see the error. COUCHDB-3199
|
+1 |
asfgit
pushed a commit
that referenced
this pull request
Mar 14, 2017
Use do_checkpoint instead of do_last_checkpoint, as last checkpoint variant assumes there are more sequences in progress, which might not be true for continuous replications. (It also looks cleaner as don't have to handle gen_server results)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary in the case where an software upgrade happens with
a more restrictive VDU function. Replicator db might end up having documents
which would not pass validation anymore, leading to a replicator manager
crash when it updates the document with an "error" state.
So in case of an "error" state allow malformed document so the user can
see the error.
COUCHDB-3199