Design doc names truncated in sidebar #330
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before:
After:
|
| color: @linkColor; | ||
| span { | ||
| width: 300px; |
There was a problem hiding this comment.
you can do:
width: @sidebarWidth - 30px;
this way it will not break if the sidebar width changes
|
left a small suggestion, looks good! |
|
+1 after addressing it (and travis is green) |
benkeen
force-pushed
the
truncate-long-view-names-in-sidebar
branch
2 times, most recently
from
bcabf90
to
a6a9ac8
Compare
|
@benkeen could you rebase and if tests pass, could you merge. |
Long design doc names displayed in the sidebar of the Docs page would
overlap with the rightmost ("+") icon. This truncates them with an
ellipsis and adds a tooltip (just a title attr) to provide a means to
let user see the full design doc name.
benkeen
force-pushed
the
truncate-long-view-names-in-sidebar
branch
from
a6a9ac8
to
aa7188a
Compare
|
Closing this PR - travis won't re-trigger for some reason. I'll link the new PR to it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Long design doc names displayed in the sidebar of the Docs page would
overlap with the rightmost ("+") icon. This truncates them with an
ellipsis and adds a tooltip (just a title attr) to provide a means to
let user see the full design doc name.