Cluster configuration fixes for 2.0 #360
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when running the testsuite in the browser tests were stopped unti confirming with `OK`
In CouchDB 2.0 we don't have `_config` on the clustered interface. We still support it on the backdoor ports. closes COUCHDB-2601 COUCHDB-2390
robertkowalski
force-pushed
the
2601-2390-config-backdoor
branch
from
9340260
to
e740ef4
Compare
`_config` is not available on a cluster, so don't offer to alter it for creating admins, changing passwords and fixing the party mode. closes COUCHDB-2601 COUCHDB-2599 COUCHDB-2390
robertkowalski
force-pushed
the
2601-2390-config-backdoor
branch
from
e740ef4
to
10e6c97
Compare
| var deferred = FauxtonAPI.Deferred(), | ||
| checked = FauxtonAPI.isRunningOnBackdoorPort(); | ||
|
|
||
| FauxtonAPI.when(checked).then(function (res) { |
There was a problem hiding this comment.
You don't need FauxtonAPI.when here. You only doing one fetch
|
todo: remove the caching just "cache" the promise |
|
@robertkowalski this looks good once you remove the caching. |
| return data; | ||
| } | ||
|
|
||
| return data; |
There was a problem hiding this comment.
minor - but: unreachable statement (can just be left out?)
|
though I didn't run it I like it - and it's a big step 2wards a usable 2.0 |
|
this got stale as user management was converted to react |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In CouchDB 2.0 we don't have
_configon the clustered interface. As user/admin management also uses _config, also hide it on a cluster.We still support it on the backdoor ports.
closes COUCHDB-2601 COUCHDB-2599 COUCHDB-2390
COUCHDB-2390