Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make velocity dependancy of velocity.ui #46

Merged
merged 3 commits into from
Aug 28, 2014
Merged

Make velocity dependancy of velocity.ui #46

merged 3 commits into from
Aug 28, 2014

Conversation

garrensmith
Copy link
Member

This will fix the velocity issue that causes the api bar not to work.

@kxepal
Copy link
Member

kxepal commented Aug 28, 2014

Suddenly, doesn't works for me and also it doesn't solves the related warning in console:

12:57:06.031 Use of getUserData() or setUserData() is deprecated.  Use WeakMap or element.dataset instead. requestNotifier.js:63
12:57:06.570 mutating the [[Prototype]] of an object will cause your code to run very slowly; instead create the object with the correct initial [[Prototype]] value using Object.create require.js:11
12:57:06.579 "Velocity UI Pack: Velocity must be loaded first. Aborting." require.js:26
12:57:06.706 window.controllers is deprecated. Do not use it for UA detection. require.js:16
12:57:06.894 Use of getPreventDefault() is deprecated.  Use defaultPrevented instead. flashblock.xml:119
12:57:10.244 "Velocity: First argument (transition.slideDownIn) was not a property map, a known action, or a registered sequence. Aborting." require.js:15

@garrensmith
Copy link
Member Author

@kxepal Could you try again. I've tweaked the dependancy management some more. Also I'm downloading an ubuntu vm right now so I can do better testing myself.

@kxepal
Copy link
Member

kxepal commented Aug 28, 2014

@garrensmith something really had changed, but still doesn't works:

14:03:00.395 TypeError: this.$(...).velocity is not a function require.js:26

@garrensmith
Copy link
Member Author

@kxepal could you test again. I've had to do a somewhat hacky fix but the only way around this stupid error.

@kxepal
Copy link
Member

kxepal commented Aug 28, 2014

oh, that fix looks untrivial

@kxepal
Copy link
Member

kxepal commented Aug 28, 2014

Hooray! No more velocity errors! API button works as it have to.

@asfgit asfgit merged commit 8de3ed3 into apache:master Aug 28, 2014
@garrensmith
Copy link
Member Author

Great! Thanks for testing. I've merged it. Sorry I forgot to squish so slightly messy.

@robertkowalski
Copy link
Member

There should land proper AMD support soon: julianshapiro/velocity#264

@kxepal kxepal mentioned this pull request Aug 31, 2014
@garrensmith garrensmith deleted the fix-velocity-loading branch January 3, 2018 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants