Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prepare React 14 update #563

Closed
wants to merge 1 commit into from
Closed

prepare React 14 update #563

wants to merge 1 commit into from

Conversation

robertkowalski
Copy link
Contributor

updates this.getDOMNode() or this.refs.foo.getDOMNode() calls
inside of React.createClass to findDOMNode

@robertkowalski
Copy link
Contributor Author

ping @michellephung @benkeen

@benkeen
Copy link
Member

benkeen commented Oct 23, 2015

+1

@robertkowalski
prepare React 14 update
f0319b1 
updates `this.getDOMNode()` or `this.refs.foo.getDOMNode()` calls
inside of `React.createClass` to `findDOMNode`
@robertkowalski
Copy link
Contributor Author

merged as a45d280

@robertkowalski robertkowalski deleted the react-14 branch October 28, 2015 14:14
asfgit pushed a commit that referenced this pull request Oct 28, 2015
@robertkowalski
prepare React 14 update
a45d280 
updates `this.getDOMNode()` or `this.refs.foo.getDOMNode()` calls
inside of `React.createClass` to `findDOMNode`

PR: #563
PR-URL: #563
Reviewed-By: Benjamin Keen <ben.keen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robertkowalski @benkeen