don't encode username/pass unless necessary #854
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This along with pouchdb/pouchdb-server#170 should fix pouchdb/express-pouchdb#430.
The goal is just to avoid encoding the username/password if we're in admin party mode and neither is required. This avoids the
http://null:@localhost
bug.Unfortunately this doesn't 100% fix the problem, because it relies on the URL of fauxton being the same as the URL of the CouchDB itself, which is not always the case. But it'll at least fix things for pouchdb-server as-is.