Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replication from local #858

Closed
wants to merge 3 commits into from
Closed

Replication from local #858

wants to merge 3 commits into from

Conversation

garrensmith
Copy link
Member

@garrensmith garrensmith commented Feb 20, 2017

This improves the way we encode usernames and passwords. So if no
username and password are required it should still work and if the user
has special characters in the url it should still work.

This extends Nolan's work and adds a test to prove its working
This improves the way we encode usernames and passwords. So if no
username and password are required it should still work and if the user
has special characters in the url it should still work.
@nolanlawson
Copy link
Member

LGTM, looking forward to replication working for pouchdb server!

@millayr
Copy link
Contributor

millayr commented Feb 20, 2017

+1 from me

@garrensmith
Copy link
Member Author

Thanks merged.

@nolanlawson
Copy link
Member

Well, I probably should have tested this before saying 👍. 😅 It actually breaks worse than before. Attempting to replicate from http://examples.cloudant.com/animaldb to a new local DB animaldb results in a replicator document looking like this:

{
  "source": {
    "headers": {},
    "url": "http://examples.cloudant.com/animaldb"
  },
  "target": {
    "headers": {},
    "url": "http://localhost:6984/animaldb"
  },
  "create_target": true
}

I'll open a PR to fix it.

@garrensmith
Copy link
Member Author

garrensmith commented Feb 20, 2017 via email

@garrensmith garrensmith deleted the replication-from-local branch January 3, 2018 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants