This repository has been archived by the owner on May 25, 2021. It is now read-only.
Set default limit to 25 #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The docs claim the limit is 25 and this was the intention but this value was never updated. The reason to set it at 25 is in case we add other index types that are unable to stream results to the client (ie, anything Lucene based). This allows us to maintain the same API across all calls regardless of index type used. COUCHDB-3143
This was passing by accident on travis because the $CWD is set differently so the test would always fail. If however you tried to run the tests locally then it would fail. Obviously the test is just wrong since we're moving the mango_cursor_text.erl file in rebar.config, and not mango_cursor.erl which is required for every index type. COUCHDB-3143
davisp
force-pushed
the
3143-fix-default-limit
branch
from
859a70e
to
29b5944
Compare
|
+1 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docs claim the limit is 25 and this was the intention but this value
was never updated. The reason to set it at 25 is in case we add other
index types that are unable to stream results to the client (ie,
anything Lucene based). This allows us to maintain the same API across
all calls regardless of index type used.
COUCHDB-3143