Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log before adding agents - fixes issue #252 #253

Merged
merged 1 commit into from
Jan 15, 2021
Merged

log before adding agents - fixes issue #252 #253

merged 1 commit into from
Jan 15, 2021

Conversation

glynnbird
Copy link
Contributor

Overview

Fixes auth scrubbing bug where JSON.stringify on the req object could produce circular references when an HTTP Agent was used.

Solution: log before adding the agent.

Testing recommendations

npm run test

GitHub issue number

Fixes issue #252

Checklist

  • Code is written and works correctly;
  • Changes are covered by tests;
  • Documentation reflects the changes;

@glynnbird glynnbird merged commit 1680101 into main Jan 15, 2021
@glynnbird glynnbird deleted the issue252 branch January 15, 2021 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant