Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

63 update engine #87

Merged
merged 2 commits into from
May 14, 2018
Merged

63 update engine #87

merged 2 commits into from
May 14, 2018

Conversation

ricellis
Copy link
Contributor

@ricellis ricellis commented May 2, 2018

Overview

Updated the minimum Node.js engine in package.json to 6. This is currently the oldest available LTS release of Node.js. Moving to a Node.js version >4 unblocks upgrades of request to versions > 2.81.0 so the workaround from fc794b2 to pin to 2.81.0 can be safely removed (although it appears that #73 already moved it to 2.83.0). With Node.js 6 it should be safe to move back to backwards compatible changes.

Testing recommendations

npm install will give a warning on Node.js versions older than 6.

GitHub issue number

#63

Checklist

  • Code is written and works correctly; - No new code package.json and request dependency version change only.
  • Changes are covered by tests; - tests pass locally for me.
  • Documentation reflects the changes; - updated README to mention the minimum version.

@glynnbird glynnbird merged commit a238de7 into apache:master May 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants