Add extra protection to databases during package purge #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnewson
force-pushed
the
postrm_remove_databases
branch
from
c3b71dd
to
82822ea
Compare
|
(I haven't ticked any of the checklist because I've genuinely not gotten that far.) |
rnewson
commented
Sep 3, 2019
rnewson
commented
Sep 3, 2019
| fi | ||
|
|
||
| pkill -u couchdb >/dev/null 2>&1 || true | ||
| db_reset couchdb/mode | ||
| db_reset couchdb/nodename | ||
| db_reset couchdb/cookie |
There was a problem hiding this comment.
probably unrelated entirely but why do we forcibly reset the debconf settings after purge? I think we should not reset the couchdb/nodename parameter if we're not purging the databases, but I don't know about the rest.
There was a problem hiding this comment.
This sequence of events should be possible, and not result in a surprise:
apt install couchdb
# configure as single node with an admin user for testing, password "admin"
# do some testing, create some DBs
apt purge couch
apt install couchdb
# re-configure couchdb for a cluster with a real admin user/password comboHave you tried this? I should test it myself before I +1 this.
rnewson
force-pushed
the
postrm_remove_databases
branch
from
82822ea
to
2b334ac
Compare
wohali
reviewed
Sep 4, 2019
| fi | ||
|
|
||
| pkill -u couchdb >/dev/null 2>&1 || true | ||
| db_reset couchdb/mode | ||
| db_reset couchdb/nodename | ||
| db_reset couchdb/cookie |
There was a problem hiding this comment.
This sequence of events should be possible, and not result in a surprise:
apt install couchdb
# configure as single node with an admin user for testing, password "admin"
# do some testing, create some DBs
apt purge couch
apt install couchdb
# re-configure couchdb for a cluster with a real admin user/password comboHave you tried this? I should test it myself before I +1 this.
|
@rnewson ping, minor comments |
rnewson
force-pushed
the
postrm_remove_databases
branch
from
2b334ac
to
7778d76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Using
apt-get --purgeremoves all CouchDB databases. This is surprising as--purgeisdefined as removing config files. Other database packages (like mysql) have an additional
debconf property for data destruction beyond config files. This PR follows the mysql package
in adding that property and defaulting it to false. This allows a purge with complete data removal if desired.
Testing recommendations
Install CouchDB, create databases, then purge the package. The .couch files should remain
in
/var/lib/couchdb.GitHub issue number
N/A
Related Pull Requests
N/A
Checklist