Add "couch_server" aggregate to _system output #3370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnewson
force-pushed
the
couch_server_system_aggregate
branch
from
6ba642d
to
9eaa75d
Compare
davisp
requested changes
Feb 15, 2021
src/couch/src/couch_server.erl
Outdated
| @@ -937,6 +938,14 @@ num_servers() -> | |||
| erlang:system_info(schedulers). | |||
|
|
|||
|
|
|||
| aggregate_queue_len() -> | |||
| N = couch_server:num_servers(), | |||
There was a problem hiding this comment.
Are you using the fully qualified external call on purpose for reasons I'm not thinking of?
There was a problem hiding this comment.
erm, nope. In the first commit it was in chttpd_node
src/chttpd/src/chttpd_node.erl
Outdated
| @@ -289,6 +290,7 @@ message_queues(Registered) -> | |||
| {Name, Length} | |||
| end, Registered). | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
White space only hunks are not awesome.
rnewson
force-pushed
the
couch_server_system_aggregate
branch
from
9eaa75d
to
379bf55
Compare
rnewson
force-pushed
the
couch_server_system_aggregate
branch
from
379bf55
to
21bc72c
Compare
This helps ease transition from singleton couch_server to multiple. The "couch_server" message queue is simply the sum of the couch_server_X message queues.
rnewson
force-pushed
the
couch_server_system_aggregate
branch
from
21bc72c
to
5724e8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This helps ease transition from singleton couch_server to
multiple. The "couch_server" message queue is simply the sum of the
couch_server_X message queues.
Testing recommendations
N/A
Related Issues or Pull Requests
#3366
Checklist
rel/overlay/etc/default.ini