-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try using rebar3 #3938
base: 3.x
Are you sure you want to change the base?
Try using rebar3 #3938
Conversation
configure
Outdated
@@ -345,7 +345,7 @@ fi | |||
# only update dependencies, when we are not in a release tarball | |||
if [ -d .git -a $SKIP_DEPS -ne 1 ]; then | |||
echo "==> updating dependencies" | |||
${REBAR} get-deps update-deps | |||
${REBAR3} get-deps update-deps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no update-deps
command. Also, you can't run multiple commands this way but have to use do
:
rebar3 do compile, ct
You also shouldn't need to run get-deps
ever. It is a backwards compat command we added after the fact even though it isn't really needed -- though can be useful like when building a docker image to first fetch the deps into a layer. So you may just be wanting rebar3 upgrade
here.
I just looked at |
Thanks for taking a look, @tsloughter. It's much appreciated. For raw dependencies, would it be feasible to turn those into empty/no-op erlang apps so they can compile and build like regular dependencies? |
If you are able to control the dependencies then yes, turning them into empty erlang apps should work. They wouldn't be included in the release, so would just be "apps" fetched and kept in |
Thanks! We do control them and that may be the easiest way to go, then |
d148054
to
efc5379
Compare
* Use 3.15.2 version which is compatible with Erlang 20 * Fauxton and docs converted to be used as rebar3 deps * Use get-deps only instead of update-deps
efc5379
to
7b419bd
Compare
Some progress
|
Given that we may be dropping OTP 20 support "soon", what happens when you try a more modern version like 3.18.0 or main? Guessing that won't help with the NIF choke? |
@jaydoane good idea to try. The version we have is pretty old. But I suspect in this case it's the issue with odd paths we expect these NIFs to have relative the top of the (top) umbrella folder vs the individual dep app folder in various contexts (eunit tests vs regular builds). |
Currently fails with: