Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Ensure replicator _active_tasks entry reports recent pending changes #623
Previously there was a race between reporting the source update sequence
In some cases that lead to pending changes being stuck. For example, if changes
The fix is to thread the last_sequence update through the changes queue to
Looks really good. I definitely like that use of lists:partition/2. Though I think for sanity we should look at routing the last_seq to the worker so that we're changing this logic as little as possible.
Still seems like it'd be easier to find the ReportSeq from the list, strip out last_seq entries, and then in the ignored empty clause just send a report_seq_done message than your two extra maybe functions.
Minor style issue and need to remove that maybe function but pretty close otherwise.