Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RAT-325 : Added check to skip expensive processing in SPDX #192

Merged
merged 2 commits into from
Jan 16, 2024

Conversation

Claudenw
Copy link
Contributor

In my small test case this changed the timing from 55 sec to 3 sec.

@ottlinger
Copy link
Contributor

Can you push a new commit? Strangely the build runs locally. Maybe GHA just needs a 2nd chance ;)

@ottlinger
Copy link
Contributor

My local builds run ok on an Ubuntu, but GHA fails .... strange.

@ottlinger
Copy link
Contributor

ottlinger commented Jan 14, 2024

@Claudenw As I merged in the changes related to RAT-346; pls rebase this branch and let us tackle the problems with the tests then. Thanks again for your help & efforts!

@Claudenw Claudenw force-pushed the RAT-325_fix_performance_degradation branch from 08cac5f to c69157d Compare January 15, 2024 06:45
@ottlinger
Copy link
Contributor

ottlinger commented Jan 16, 2024

The changes look promising; I will merge and we will try on the openmeetings project. Thanks again. I will add a changelog entry once it is on master!

@ottlinger ottlinger merged commit af0452a into apache:master Jan 16, 2024
16 checks passed
@ottlinger
Copy link
Contributor

ottlinger commented Jan 16, 2024

@Claudenw I ran the current SNAPSHOT on openmeetings and realized that all processed files are printed out on level INFO. I think we should change this to DEBUG as people complained about log spam of RAT runs in previous releases.

I will apply the change to master directly - sorry for the noise!

@Claudenw Claudenw deleted the RAT-325_fix_performance_degradation branch April 23, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants