RAT-346: warn on duplicate license family

[Claudenw]

Added code to warn on duplicate license or license family.

Also upgraded to Junit 5 as it was needed for the testing.

[ottlinger]

btw: I guess that this new behaviour is the cause of https://issues.apache.org/jira/browse/RAT-344 ;)

[ottlinger]

@Claudenw not sure why you removed the API module ..... if I understood it correctly we want to harmonize things among all the available RAT-options (e.g. Ant,Maven,CLI). I'd assume an API module to be handy in that regard.

[ottlinger]

@jbonofre just fyi - a great deal of changes will come in with the jUnit5 update.

[jbonofre]

@ottlinger thanks for the heads up. I will be back on rat work tomorrow.

[Claudenw]

@ottlinger thx for the quick review

I'll make the change to the @tempdir annotation -- I think there are 2 files where it is needed.

I removed the API module because it consisted of a) class files that were not being used in the code but that were misleading in name; and more importantly b) because there were a number of test cases that would have been converted to Junit5 only to be removed again later.

The harmonization is not necessarily the use of a single API module but rather that the options in each of the UIs should be similarly constructed (same basic phrasing) not have 2 UIs where one says "--enable-default-licenses" (default off) and the other says "--disable-default-licenses" (default on). Also there are options that have been added to one UI that are general in nature (i.e. not part of managing the specific platform the UI is on) and are not available in the other UIs.

I will remove the commented out code. I should have before I submitted this pull request, but skipped it in favor of getting this code change infront of more eyes quickly.

I also have to make a pass to update javadocs.

@jbonofre Most of the changes in this request are the migration to Junit 5. The significant changes are the creation of the classes in the o.a.r..utils directory, the addition of methods to set the associated properties in ReportConfiguration along with the tests for those classes and changes.

The request was to warn on duplication so the solution submitted does the following:

• Creates a ReportingSet class that is a SortedSet implementation (wrapping and delegating to a SortedSet). it intercepts the calls to add and addAll to determine if the new elements are already in the set and take an action.

  • If logging is enabled (not set to None on the very thing logging wrapper Log) write a message about the collision to the log at the specific level.
  • If the internal action (ReportingSet.Option) is set to IGNORE the change is ignored, OVERWRITE the old entry is replaced, FAIL an exception is thrown.

Finally the ReportingSet has an instance variable called duplicateFmt that is a Function<T,String> that produces the information to display in the message.

The change to ReportConfiguration are to use ReportingSet to contain the Licenses and LicenseFamilies, and supporting methods to configure (as noted above).

[Claudenw]

@ottlinger Thanks for taking the time to clean this up. It looks good to me.

[ottlinger]

@Claudenw pls give a ping if you have any local changes that need to be pushed. I`d love to merge this PR in order to continue analysing the problems on #192

[ottlinger]

Thanks @Claudenw for the simplifications and the migration efforts!